[webkit-reviews] review requested: [Bug 6821] Fix for 5983 will not always update hover correctly. : [Attachment 6197] Updated patch

[bugzilla-request-daemon at opendarwin.org]

opendarwin.org at mitzpettel.com has asked  for review:
Bug 6821: Fix for 5983 will not always update hover correctly.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6821

Attachment 6197: Updated patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6197&action=edit

------- Additional Comments from opendarwin.org at mitzpettel.com
(In reply to comment #8)
> (1) You need to cancel the timer if the FrameView goes away.

Done. How come the relayout timer doesn't need to be canceled there?

> (2) You need to cancel the timer if a mouse move comes in before the timer
> fires.

Done.

> (3) Doesn't :active have all of the same issues as :hover?  It seems like the

> exact same bugs apply to :active.

It has some of the same issues (the bug 5983 ones). I added code to trim the
rendererless end of the active chain and reset m_active and m_inActiveChain,
but since the active chain is locked, I think there's no need to post a mouse
event.

ChangeLog entry and test still missing from this patch, so r- anyway.