[webkit-reviews] review granted: [Bug 11998] Incorrect serialization of quotation marks in XML attributes. : [Attachment 12110] proposed fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Dec 29 15:32:39 PST 2006


mitz at webkit.org has granted mitz at webkit.org's request for review:
Bug 11998: Incorrect serialization of quotation marks in XML attributes.
http://bugs.webkit.org/show_bug.cgi?id=11998

Attachment 12110: proposed fix
http://bugs.webkit.org/attachment.cgi?id=12110&action=edit

------- Additional Comments from mitz at webkit.org
+      document.getElementById("result").textContent += ": " + (new
XMLSerializer()).serializeToString(document.getElementsByTagName('div')[1]);

Doesn't work so well with the initial text in result (I guess originally it was
just FAIL)

The patch looks very straightforward, so assuming it doesn't affect any
existing tests, r=me.



More information about the webkit-reviews mailing list