[webkit-reviews] review granted: [Bug 12007] SVGColor::setRGBColor color creates/deletes many strings, slowing down parsing : [Attachment 12100] Better patch

[bugzilla-request-daemon at macosforge.org]

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 12007: SVGColor::setRGBColor color creates/deletes many strings, slowing
down parsing
http://bugs.webkit.org/show_bug.cgi?id=12007

Attachment 12100: Better patch
http://bugs.webkit.org/attachment.cgi?id=12100&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Looks great.

It appears you didn't change any of the HTML Color parsing code paths, which is
good.

expectsValid needs to check the set value (make sure it set correctly).  And I
think you coulud add a few more valid tests (for leading/tailing spaces,
commas, etc.)

With a few more tests and the expectedValid fix, feel free to land!