[webkit-reviews] review denied: [Bug 9454] CSS2: Language not inherited from parent element : [Attachment 12107] Proposed patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Dec 29 12:04:33 PST 2006

Sam Weinig <sam at webkit.org> has denied Sam Weinig <sam at webkit.org>'s request
for review:
Bug 9454: CSS2: Language not inherited from parent element

Attachment 12107: Proposed patch

------- Additional Comments from Sam Weinig <sam at webkit.org>
Nice to see this finally getting ported over.  I think it would be appropriate
to add a comment/FIXME or two about the missing features (ie, no support for
HTTP content-language or xml:lang (though as you explained that has not been
defined)).  We also usually put the patch, the tests (and their expected
results) and the ChangeLogs together in one patch to be easily landed.	We have
a prepare-ChangeLog script to make the ChangeLog and svn-create-patch script to
create the patch.  

Only one semi-color required here.

+		 Node *n = e->parent();;

I also have a few style nits.

We put the * on the otherside

+		 Node *n = e->parent();;

Single line if statements don't get curly-braces.

+		     if (n->isElementNode()) {
+			 value =
+		     }

r- for now.

More information about the webkit-reviews mailing list