[webkit-reviews] review requested: [Bug 12007] SVGColor::setRGBColor color creates/deletes many strings, slowing down parsing : [Attachment 12100] Better patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Dec 29 03:25:00 PST 2006


Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 12007: SVGColor::setRGBColor color creates/deletes many strings, slowing
down parsing
http://bugs.webkit.org/show_bug.cgi?id=12007

Attachment 12100: Better patch
http://bugs.webkit.org/attachment.cgi?id=12100&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This should address most of the issues. Unfortunately we still seem to need the
"empty" SVGPaint, since
we need to be able to differ between no fill specified at all or invalid fill
specified. In the former case the
default or inherited value should be kept, in the latter case it should use
black paint.
The testcase should be much better now.
Cheers,

Rob.



More information about the webkit-reviews mailing list