[webkit-reviews] review denied: [Bug 12007] SVGColor::setRGBColor color creates/deletes many strings, slowing down parsing : [Attachment 12089] First attempt

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Dec 28 17:46:10 PST 2006


Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 12007: SVGColor::setRGBColor color creates/deletes many strings, slowing
down parsing
http://bugs.webkit.org/show_bug.cgi?id=12007

Attachment 12089: First attempt
http://bugs.webkit.org/attachment.cgi?id=12089&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
The patch looks pretty good.

The test case is busted.  You never actually use "value".

I don't think you need to init RGBA32 to transparent (at least not outside the
parse function).

It's still unfortunate that we're creating new SVGPaints even for invalid
colors.



More information about the webkit-reviews mailing list