[webkit-reviews] review requested: [Bug 12013] REGRESSION: <pattern> in objectBoundingBox mode are broken. : [Attachment 12090] Initial patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Dec 28 16:34:25 PST 2006


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 12013: REGRESSION: <pattern> in objectBoundingBox mode are broken.
http://bugs.webkit.org/show_bug.cgi?id=12013

Attachment 12090: Initial patch
http://bugs.webkit.org/attachment.cgi?id=12090&action=edit

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Attaching patch which reworks pattern handling to actually work in all
patternUnits/patternContentUnits combinations. Fixes quite some testcases:
coords-units-01-b.svg (also work with run-safari now, under any zoom level)
pattern-in-defs.svg (pattern buffer allocation now clipped against target bbox)

js-update-pattern.svg (live update really works now! all repainting is done
properly)

Also get rid of SVGResourceListener, and the whole resourceNotification()
logic.
This also fixes gradients causing objects to redraw twice.



More information about the webkit-reviews mailing list