[webkit-reviews] review requested: [Bug 12018] Cleanup of CSSRule and its subclasses. : [Attachment 12087] patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Dec 28 15:05:41 PST 2006

Sam Weinig <sam at webkit.org> has asked  for review:
Bug 12018: Cleanup of CSSRule and its subclasses.

Attachment 12087: patch

------- Additional Comments from Sam Weinig <sam at webkit.org>
- Make CSSRule::type() virtual instead of using a member variable.
- Make CSSRule::setCssText() virtual and take an ExceptionCode argument to
conform to the spec.  Subclasses are also stubbed with the method and a FIXME
comment urging for their implementation.
- Cleanup cssText() implementations.
- General style cleanup.

More information about the webkit-reviews mailing list