[webkit-reviews] review granted: [Bug 11882] Need a way to regression test .webarchive output files : [Attachment 12036] Patch v2

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Dec 27 22:33:59 PST 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11882: Need a way to regression test .webarchive output files

Attachment 12036: Patch v2

------- Additional Comments from Darin Adler <darin at apple.com>
Typo: "excercise" in ChangeLog.

I think it would be better to not implement dumpAsWebArchive in DumpRenderTree
on platforms that don't have web archive support. That way, the test can check
the existence of the function and indicate the error.

It would be way better if the data was dumped in text format for resource types
that are text/ -- we should probably teach DumpRenderTree to do that.

Fine first step!


More information about the webkit-reviews mailing list