[webkit-reviews] review granted: [Bug 11359] Incomplete repaint of
table cell's collapsed border when changing only the cell :
[Attachment 12072] Override repaint rect computation for table cells
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Wed Dec 27 22:30:45 PST 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11359: Incomplete repaint of table cell's collapsed border when changing
only the cell
http://bugs.webkit.org/show_bug.cgi?id=11359
Attachment 12072: Override repaint rect computation for table cells
http://bugs.webkit.org/attachment.cgi?id=12072&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+ if (RenderTableCell* above = table()->cellAbove(this)) {
+ left = max(left, above->borderLeft(true));
+ right = max(right, above->borderRight(true));
+ }
Indenting mistake.
+ int borderLeft() const { return borderLeft(false); }
Why overloading instead of a default value for the parameter? This seems OK,
but normally I'd only overload if I didn't want the parameter value inlined.
r=me
More information about the webkit-reviews
mailing list