[webkit-reviews] review granted: [Bug 12001] marker shorthand property only sets marker-start : [Attachment 12071] Updated patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Dec 27 22:23:37 PST 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12001: marker shorthand property only sets marker-start

Attachment 12071: Updated patch

------- Additional Comments from Darin Adler <darin at apple.com>
This looks right. The code in parse4Values is similar, and I assume you looked
there to understand the proper technique.

+	 CSSValue *value = parsedProperties[numParsedProperties - 1]->value();

I know the code you copied from is formatted this way, but it should be
CSSValue* with the * next to the type.


More information about the webkit-reviews mailing list