[webkit-reviews] review granted: [Bug 11108] Replace usage of split by proper parsers : [Attachment 12070] Better diff

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Dec 27 13:24:00 PST 2006


Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 11108: Replace usage of split by proper parsers
http://bugs.webkit.org/show_bug.cgi?id=11108

Attachment 12070: Better diff
http://bugs.webkit.org/attachment.cgi?id=12070&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This looks great.

We definitely need more invalid path tests.

I think you could rename SVGPathUtils to SVGPathUtilities for clarity, but
that's not a huge deal.

r=me



More information about the webkit-reviews mailing list