[webkit-reviews] review requested: [Bug 11973] WebKit does not respect boundingbox percentages larger than 1 (aka 100%) : [Attachment 12025] better partial fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Dec 25 23:19:28 PST 2006


Eric Seidel <macdome at opendarwin.org> has asked	for review:
Bug 11973: WebKit does not respect boundingbox percentages larger than 1 (aka
100%)
http://bugs.webkit.org/show_bug.cgi?id=11973

Attachment 12025: better partial fix
http://bugs.webkit.org/attachment.cgi?id=12025&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
It turns out everything is actually OK with this patch.

Here's the fallout from these changes:

custom/js-late-gradient-and-object-creation
custom/js-late-gradient-creation

Have changed results.  The tests were depending on a bug in WebKit which is now
fixed. :)  (At least I believe that to be the case.  When comparing with Opera,
our results now match.)

custom/large-bounding-box-percents.

This is a new test case which now actually works on TOT.

custom/pattern-in-defs

This test case now intermittently fails, depending on how much free memory the
machine has (I think that's the reason).  This will be fixed for real once we
are smarter about allocating pattern tile image buffers at their physical
rendered size, instead of at some super-large logical size.



More information about the webkit-reviews mailing list