[webkit-reviews] review granted: [Bug 11952] style changes made through CSSMediaRule functions insertRule() and deleteRule do not show up on the screen : [Attachment 11991] patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Dec 23 23:25:45 PST 2006


Geoffrey Garen <ggaren at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 11952: style changes made through CSSMediaRule functions insertRule() and
deleteRule do not show up on the screen
http://bugs.webkit.org/show_bug.cgi?id=11952

Attachment 11991: patch
http://bugs.webkit.org/attachment.cgi?id=11991&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

styleSheet() is a function that can return NULL, and other spots in WebCore
chck for NULL, so I think you should, too. If you know that styleSheet() should
never be NULL in this case (and, according to the spec, I don't think it
should), then use an ASSERT instead. Eventually, it may be worth clearing up
exactly when styleSheet() can return NULL. (I believe it's only in the case of
a computed style declaration.)



More information about the webkit-reviews mailing list