[webkit-reviews] review granted: [Bug 11917] setlocale() can return null : [Attachment 11956] patch to CString

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Dec 22 17:48:37 PST 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11917: setlocale() can return null
http://bugs.webkit.org/show_bug.cgi?id=11917

Attachment 11956: patch to CString
http://bugs.webkit.org/attachment.cgi?id=11956&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    length = data = c;

We don't normally do multiple assignments on a line like this, and I think it's
a little strange to set length to a null pointer to zero it. Instead it should
be "length = 0; data = 0;" on two separate lines.

Otherwise, looks great. r=me



More information about the webkit-reviews mailing list