[webkit-reviews] review denied: [Bug 11588] offsetwidth gives different values in Firefox and Safari in certain tables : [Attachment 11968] This contains a sample fix for the offsetwidth issue

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11588: offsetwidth gives different values in Firefox and Safari in certain
tables
http://bugs.webkit.org/show_bug.cgi?id=11588

Attachment 11968: This contains a sample fix for the offsetwidth issue
http://bugs.webkit.org/attachment.cgi?id=11968&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks pretty good to me.

I'd like to understand whether the case where numAuto == nEffCols is really a
special case, or if the general algorithm needs to be corrected.

This change needs a layout test and change log.

Has someone run the layout tests with this patch in place? does this affect the
results of any of the layout tests?

Formatting is not correct in this patch. For example, it uses tabs for
indentation, and this:

+ int w = available / nCols -- ;

should be formatted like this:

    int w = available / nCols--;

and this:

+ }else{

should be formatted like this:

    } else {

Because of these concerns, review-.