[webkit-reviews] review denied: [Bug 11924] WebCore crash on 64-bit code when loading a web page with a table tag : [Attachment 11961] Martin's patch in Comment #0

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11924: WebCore crash on 64-bit code when loading a web page with a table
tag
http://bugs.webkit.org/show_bug.cgi?id=11924

Attachment 11961: Martin's patch in Comment #0
http://bugs.webkit.org/attachment.cgi?id=11961&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This is a good fix for the numeric overflow.

However, the crash indicates that the caller doesn't handle the case where
ensureRows returns false. That should also be fixed. The callers that don't
check are addChild and recalcCells. addCell does check.

Setting review- on this because it needs change log and a test case and should
also fix the callers that don't check the return value from ensureRows.