[webkit-reviews] review denied: [Bug 11346] _blank is assigned to Window name : [Attachment 11964] The attachment is a fix for the issue

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Dec 22 06:49:35 PST 2006

David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has denied David Kilzer
(ddkilzer) <ddkilzer at kilzer.net>'s request for review:
Bug 11346: _blank is assigned to Window name

Attachment 11964: The attachment is a fix for the issue

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Thanks for the patch!  There are still some issues that need to be cleaned up,

1. Please use WebKitTools/Scripts/prepare-ChangeLog to generate your own
ChangeLog entry, then use WebKitTools/Scripts/svn-create-patch to generate the
patch.	More info here: http://webkit.org/coding/contributing.html

2. No tabs are allowed in the source code.  Please use spaces instead.	More
info here:  http://webkit.org/coding/coding-style.html

3. A manual test in WebCore/manual-tests should be included with the patch per
Maciej in Comment #8.

Almost there!

More information about the webkit-reviews mailing list