[webkit-reviews] review requested: [Bug 11917] setlocale() can return null : [Attachment 11956] patch to CString

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Dec 21 14:26:19 PST 2006

David Carson <dacarson at gmail.com> has asked  for review:
Bug 11917: setlocale() can return null

Attachment 11956: patch to CString

------- Additional Comments from David Carson <dacarson at gmail.com>
Took the approach that CString should support holding null char pointers.
Had no luck with 24fun JSBench giving consistant results with no changes, so
the performance impact of this change I am not sure of.
Would love feedback from a non-mac port as setlocale() is only used in
non-darwin builds.

More information about the webkit-reviews mailing list