[webkit-reviews] review granted: [Bug 11888] REGRESSION (r18320): Web Inspector panes broken : [Attachment 11943] Patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Dec 20 21:41:02 PST 2006


Adam Roben <aroben at apple.com> has granted Adam Roben <aroben at apple.com>'s
request for review:
Bug 11888: REGRESSION (r18320): Web Inspector panes broken
http://bugs.webkit.org/show_bug.cgi?id=11888

Attachment 11943: Patch
http://bugs.webkit.org/attachment.cgi?id=11943&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+	 Don't throw an exception when setting the value of a
SSStyleDeclaration.

Typo: _C_SSStyleDeclaration

+	 if (value->isNull() ||
frame->settings()->shouldUseDashboardBackwardCompatibilityMode()) {

It would be great to have a comment here about why we're allowing setting
properties to null.

r=me



More information about the webkit-reviews mailing list