[webkit-reviews] review granted: [Bug 11879] Patterns on fill/stroke of text doesn't work : [Attachment 11919] Updated patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Tue Dec 19 12:26:41 PST 2006


Oliver Hunt <ojh16 at student.canterbury.ac.nz> has granted Oliver Hunt
<ojh16 at student.canterbury.ac.nz>'s request for review:
Bug 11879: Patterns on fill/stroke of text doesn't work
http://bugs.webkit.org/show_bug.cgi?id=11879

Attachment 11919: Updated patch
http://bugs.webkit.org/attachment.cgi?id=11919&action=edit

------- Additional Comments from Oliver Hunt <ojh16 at student.canterbury.ac.nz>
Fix indentation of + if (isPaintingText()) 

then it's landable

-	 if (isPaintingText()) {
-	     const_cast<RenderObject*>(object)->style()->setColor(Color());
+ 
+	if (isPaintingText()) 
	     context->setTextDrawingMode(cTextFill);
-	 }
     }



More information about the webkit-reviews mailing list