[webkit-reviews] review denied: [Bug 11879] Patterns on fill/stroke of text doesn't work : [Attachment 11918] Initial patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Tue Dec 19 12:16:50 PST 2006


Oliver Hunt <ojh16 at student.canterbury.ac.nz> has denied Oliver Hunt
<ojh16 at student.canterbury.ac.nz>'s request for review:
Bug 11879: Patterns on fill/stroke of text doesn't work
http://bugs.webkit.org/show_bug.cgi?id=11879

Attachment 11918: Initial patch
http://bugs.webkit.org/attachment.cgi?id=11918&action=edit

------- Additional Comments from Oliver Hunt <ojh16 at student.canterbury.ac.nz>
In

-    if (!m_paintServer || !m_paintServer->activeClient() ||
m_ignoreAttributeChanges)
+    if (ownerDocument()->parsing() || !attached() || !m_paintServer ||
m_ignoreAttributeChanges)

Move the pure bool checks to the beginning of the condition



More information about the webkit-reviews mailing list