[webkit-reviews] review cancelled: [Bug 11839] Webarchive fails to save CSS files in @import statements : [Attachment 11898] Patch v2

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Tue Dec 19 11:08:58 PST 2006

David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has cancelled Darin Adler
<darin at apple.com>'s request for review:
Bug 11839: Webarchive fails to save CSS files in @import statements

Attachment 11898: Patch v2

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Clearing review flag.  I want to fix some of the issues raised in Comment #12,
specifically item #2 (recursion vs. iteration), item #3 (containsObject: on
NSArray) and the Internal vs. Private issue.

The choice to "reuse" the NSMutableArray and call containsObject: on it was a
conscious one.	I felt that most web pages would have a relatively small number
of total stylesheets included in a hierarchical fashion (on the order of 10),
and that the performance benefit from creating another data structure just for
bookkeeping of duplicates was "worse" than performing a containsObject: on an
existing data structure with such a small number of objects.  (I considered
this "premature optimization".)

However, I don't have any basis for the "average" number of hierarchically
included stylesheets per web page on the Internet (other than personal
experience), and I didn't test the performance difference between running
containsObject: on an NSArray with 10+ objects and an NSSet with 10+ objects to
measure the performance drop-off.

More information about the webkit-reviews mailing list