[webkit-reviews] review granted: [Bug 11839] Webarchive fails to save CSS files in @import statements : [Attachment 11898] Patch v2

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Tue Dec 19 07:48:01 PST 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11839: Webarchive fails to save CSS files in @import statements

Attachment 11898: Patch v2

------- Additional Comments from Darin Adler <darin at apple.com>
The future direction for this code is:

    1) to be converted to C++ and moved to WebCore
    2) to eschew recursive algorithms and use iterative algorithms with data
for context rather than using the processor stack
    3) to never do an operation like containsObject: on an array, since that's
O(n) -- we need to use sets instead in cases like that

Regarding the word "Private" in WebKit, that's used to mean "for possible use
internally in OS X". The word "Internal" means "to be used only inside WebKit".
Thus these categories should be using the word Internal, not Private.

We need a way to do automated tests of this code.

Anyway, r=me

More information about the webkit-reviews mailing list