[webkit-reviews] review denied: [Bug 11610]
XMLHttpRequest.onreadystatechange doesn't provide access to
the request object : [Attachment 11865] proposed fix
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Fri Dec 15 13:11:02 PST 2006
Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11610: XMLHttpRequest.onreadystatechange doesn't provide access to the
request object
http://bugs.webkit.org/show_bug.cgi?id=11610
Attachment 11865: proposed fix
http://bugs.webkit.org/attachment.cgi?id=11865&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+#include "config.h"
+#include "EventTarget.h"
+#include "xmlhttprequest.h"
+
+#include "EventTargetNode.h"
Space should be after EventTarget.h.
refEventTarget and derefEventTarget could be private instead of protected.
Derived classes need to override them, but that can be done regardless of
private vs. protected. And derived classes do not need to call them. So private
would be slightly better.
r=me
More information about the webkit-reviews
mailing list