[webkit-reviews] review denied: [Bug 11824] CSSStyleSheet.title property is always null : [Attachment 11845] Improved testcase + patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Dec 14 14:04:20 PST 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11824: CSSStyleSheet.title property is always null

Attachment 11845: Improved testcase + patch

------- Additional Comments from Darin Adler <darin at apple.com>
-    void childrenChanged(Node*);
+    void childrenChanged(Element*);

This has the same overloading problem as the first patch; changing the type of
the parameter prevents it from properly overriding the function in the base

The rest looks basically good. But what about SVG style elements?

More information about the webkit-reviews mailing list