[webkit-reviews] review denied: [Bug 11824] CSSStyleSheet.title property is always null : [Attachment 11842] Improved patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Dec 14 13:27:54 PST 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11824: CSSStyleSheet.title property is always null

Attachment 11842: Improved patch

------- Additional Comments from Darin Adler <darin at apple.com>
+		 m_sheet->setTitle(static_cast<HTMLElement*>(e)->title());

title() is just a convenience to get the title attribute. It can be moved to
Element if we want to avoid the type cast. Or we can call
getAttribute(titleAttr) here. I suggest not limiting this to HTML elements,
unless there's a reason to. I'd like the titles to work for SVG style elements

More information about the webkit-reviews mailing list