[webkit-reviews] review denied: [Bug 11824] CSSStyleSheet.title property is always null : [Attachment 11840] First attempt

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Dec 14 12:12:57 PST 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11824: CSSStyleSheet.title property is always null

Attachment 11840: First attempt

------- Additional Comments from Darin Adler <darin at apple.com>
-    void childrenChanged(Node*);
+    void childrenChanged(Node*, const String& = String());

This is not a good change. Even though the declaration does not say so, this is
an override of the childrenChanged function from Node.

By changing the parameters this no longer overrides the Node function, so
callers that call the virtual function on Node won't call this function any
more. I think this subtle semantic change probably creates bugs.

To make this clearer, the virtual keyword should be added to these functions in
StyleElement.h. And we need to rethink how to do this -- I think it should be a
separate function rather than a new parameter to childrenChanged.

More information about the webkit-reviews mailing list