[webkit-reviews] review denied: [Bug 11820] Make the Windows port
compile again : [Attachment 11833] Fix windows build bustage
as of r18196
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Thu Dec 14 09:55:04 PST 2006
Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11820: Make the Windows port compile again
http://bugs.webkit.org/show_bug.cgi?id=11820
Attachment 11833: Fix windows build bustage as of r18196
http://bugs.webkit.org/attachment.cgi?id=11833&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
The change to FormState.h is incorrect. People who manipulate FormState objects
do need to include HTMLFormElement.h, but FormState.h itself does not. You can
successfully call values() on a FormState object without ever including
HTMLFormElement.h for example.
The rest of this looks OK.
More information about the webkit-reviews
mailing list