[webkit-reviews] review granted: [Bug 11053] XMLHttpRequest should be an EventTarget : [Attachment 11815] proposed patch

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11053: XMLHttpRequest should be an EventTarget
http://bugs.webkit.org/show_bug.cgi?id=11053

Attachment 11815: proposed patch
http://bugs.webkit.org/attachment.cgi?id=11815&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

+    typedef HashMap<AtomicStringImpl*,  ListenerVector> EventListenersMap;

Two spaces here.

For this code:

+    XMLHttpRequest::EventListenersMap& eventListeners =
m_impl->eventListeners();
+    for (XMLHttpRequest::EventListenersMap::iterator mapIter =
eventListeners.begin(); mapIter != eventListeners.end(); ++mapIter) {
+	 for (XMLHttpRequest::ListenerVector::iterator vecIter =
mapIter->second.begin(); vecIter != mapIter->second.end(); ++vecIter) {

I'd do it like this:

    typedef XMLHttpRequest::EventListenersMap ListenerMap;
    typedef XMLHttpRequest:: ListenerVector ListenerVector;
    ListenerMap& eventListeners = m_impl->eventListeners();
    for (ListenerMap::iterator mapIter = eventListeners.begin(); mapIter !=
eventListeners.end(); ++mapIter) {
	for (ListenerVector::iterator vecIter = mapIter->second.begin();
vecIter != mapIter->second.end(); ++vecIter) {