[webkit-reviews] review denied: [Bug 11746] REGRESSION(r14931): Outlook Web Access incorrectly positions the insertion point when replying to e-mail : [Attachment 11790] Patch v3

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Dec 11 21:27:03 PST 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11746: REGRESSION(r14931): Outlook Web Access incorrectly positions the
insertion point when replying to e-mail
http://bugs.webkit.org/show_bug.cgi?id=11746

Attachment 11790: Patch v3
http://bugs.webkit.org/attachment.cgi?id=11790&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This approach to sending the caret to the bottom of the text area:

+	     eventSender.keyDown(String.fromCharCode(0xf701), ["metaKey"]);


is entirely Macintosh-specific. I think it would be better to not rely on that
and the eventSender for tests that would otherwise be more portable.

I think that ta.setSelectionRange(10000, 10000) will do the job just as well
without being platform-specific.

I think the comment should include the URL
<http://bugs.webkit.org/show_bug.cgi?id=11746#c16>.



More information about the webkit-reviews mailing list