[webkit-reviews] review denied: [Bug 11431] ARM platform has some byte alignment issues : [Attachment 11307] Corrected patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Dec 11 13:35:53 PST 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11431: ARM platform has some byte alignment issues

Attachment 11307: Corrected patch

------- Additional Comments from Darin Adler <darin at apple.com>
Given Maciej's comment, this is review- for the WebCore. The right fix for
WebCore is to compile with -fno-strict-aliasing.

+const union {

I think this should be "static const".

Does this create a framework init function on Mac OS X? Have you tried this on
OS X? I suspect this may create a framework init function, and if it does,
we'll need a different solution for OS X, because we can't have any
initializers that involve running code.

So review- on both halves. If we verify that the JavaScriptCore half works on
OS X without creating a framework initialization function, then that half is
good to go.

More information about the webkit-reviews mailing list