[webkit-reviews] review requested: [Bug 11790] No way to initialize ResourceResponse::m_httpHeaderFields : [Attachment 11783] patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Dec 8 18:18:31 PST 2006

MorganL <morganl.webkit at yahoo.com> has asked  for review:
Bug 11790: No way to initialize ResourceResponse::m_httpHeaderFields

Attachment 11783: patch

------- Additional Comments from MorganL <morganl.webkit at yahoo.com>
This patch adds the proposed setHTTPHeaderField method.

I understand that the mac port gets around this bug by reading fields out of
the NSURLResponse, so one could argue that there should be some equivalent
'platform response handle' that is stored on the ResourceResponse, and then the
platform ports should implement updateResourceResponse.  However, that is
overkill for some ports, and since everything else is settable on this class, I
think it makes sense to define this method.

More information about the webkit-reviews mailing list