[webkit-reviews] review granted: [Bug 11777] Crash when using
XMLSerializer.serializeToString() on documentless,
DocumentType nodes. : [Attachment 11767] patch
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Thu Dec 7 23:12:01 PST 2006
Geoffrey Garen <ggaren at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 11777: Crash when using XMLSerializer.serializeToString() on documentless,
DocumentType nodes.
http://bugs.webkit.org/show_bug.cgi?id=11777
Attachment 11767: patch
http://bugs.webkit.org/attachment.cgi?id=11767&action=edit
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
+ if (node->nodeType() == Node::DOCUMENT_TYPE_NODE && !node->document()) {
It's true that only the DocumentType node can have a NULL document, but I don't
see any need to test for the node being a DocumentType node. !node->document()
should do.
r=me
More information about the webkit-reviews
mailing list