[webkit-reviews] review requested: [Bug 11749]
ScrollBar::setProportion() calls updateThumbProportion()
unnecessarily : [Attachment 11731] patch v1
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Mon Dec 4 15:10:48 PST 2006
Don Gibson <dgibson77 at gmail.com> has asked for review:
Bug 11749: ScrollBar::setProportion() calls updateThumbProportion()
unnecessarily
http://bugs.webkit.org/show_bug.cgi?id=11749
Attachment 11731: patch v1
http://bugs.webkit.org/attachment.cgi?id=11731&action=edit
------- Additional Comments from Don Gibson <dgibson77 at gmail.com>
The simplest possible fix. I could have made setProportion() return a bool
(like setPosition() does) or check that its arguments were positive, but I
didn't have a particular reason to do so.
More information about the webkit-reviews
mailing list