[webkit-reviews] review requested: [Bug 11718] REGRESSION: When I mouse up after dragging a selection outside of a iframe, the iframe continues to scroll automatically. : [Attachment 11714] proposed fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Dec 2 12:16:30 PST 2006


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 11718: REGRESSION: When I mouse up after dragging a selection outside of a
iframe, the iframe continues to scroll automatically.
http://bugs.webkit.org/show_bug.cgi?id=11718

Attachment 11714: proposed fix
http://bugs.webkit.org/attachment.cgi?id=11714&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This fix makes an EventHandler hold a reference to a subframe's node in
m_mousePressNode - previously, this data member wasn't reset for subframe
events, continuing to reference nodes from earlier actions.

There seems to be a lot of duplication in EventHandler data members at the
moment (m_mousePressNode vs. m_clickNode; m_bMousePressed vs. m_mousePressed).
I chose not to attempt merging any of these in this patch, and plan to file a
follow-up bug.



More information about the webkit-reviews mailing list