[webkit-reviews] review requested: [Bug 10574] New password fields: Shouldn't be able to select individual characters : [Attachment 10329] preliminary patch

[bugzilla-request-daemon at opendarwin.org]

Adele Peterson <adele at apple.com> has asked  for review:
Bug 10574: New password fields: Shouldn't be able to select individual
characters
http://bugzilla.opendarwin.org/show_bug.cgi?id=10574

Attachment 10329: preliminary patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10329&action=edit

------- Additional Comments from Adele Peterson <adele at apple.com>
This is a preliminary patch.  I'd like to get feedback on a few issues.

- Is this a feature that other platforms will want?  If not, we'll need to make
this specific to Mac.  At the very least, every platform needs to avoid
identifying word boundaries with selection.  This patch has the nice side
effect of achieving that.

- Does the selection adjustment belong in the text field code?	The frame could
just adjust it itself.

- Is setSelection too low level for this adjustment?  On the plus side, every
selection made will go through this path.  However, other similar adjustments
happen at a higher level- like when the events occur.  But there are a lot of
editing functions that can cause a selection, so its nice to catch it at a
central location.

thanks in advance!