[webkit-reviews] review denied: [Bug 10640] Auto-generate 10 more
Objective-C DOM HTML bindings : [Attachment 10317] patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Wed Aug 30 10:45:15 PDT 2006
Timothy Hatcher <timothy at hatcher.name> has denied Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 10640: Auto-generate 10 more Objective-C DOM HTML bindings
http://bugzilla.opendarwin.org/show_bug.cgi?id=10640
Attachment 10317: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10317&action=edit
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This looks good.
One thing:
+ push(@implContent, " $exceptionInit\n");
+ push(@implContent, " return $getterContent;\n");
+ push(@implContent, " $exceptionRaiseOnError\n");
That will never raise on error, since the return happens first. Should
$exceptionRaiseOnError be appended before return?
More information about the webkit-reviews
mailing list