[webkit-reviews] review denied: [Bug 10634] -webView:dragDestinationActionMaskForDraggingInfo: is ignored : [Attachment 10311] Fix file drags not natively understood by WebKit

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Aug 29 19:56:37 PDT 2006

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10634: -webView:dragDestinationActionMaskForDraggingInfo: is ignored

Attachment 10311: Fix file drags not natively understood by WebKit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
A couple nits.

1.  * ChangeLog doesn't need to be in the changelog.  (That often happens when
you run prepare-ChangeLog twice.)

2.  Normally changes require a copyright line.	In this case, since these are <
5 line changes, they probably don't.  But I just thought I should mention it
for the future.

3.  Generally WebKit tries to avoid else statements after returns (as they're
unnecessary.)	 _web_dragOperationForDraggingInfo could be written cleaner by
simply returning NSDragOperationCopy inside the if block and returning
NSDragOperationNone outside. Execution only hits the outer return if it didn't
trip the if.

Otherwise looks good.

I think we should do one more round on this patch to fix the nits.  (Since it's
your first patch, it's good to be extra picky.)  But the substance looks fine.

More information about the webkit-reviews mailing list