[webkit-reviews] review granted: [Bug 10604] Make regression
testing work with Qt (Adding KIO support) : [Attachment
10271] Replace libcurl usage by KIO
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Aug 29 15:20:18 PDT 2006
Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10604: Make regression testing work with Qt (Adding KIO support)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
Attachment 10271: Replace libcurl usage by KIO
http://bugzilla.opendarwin.org/attachment.cgi?id=10271&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
style: (no {} needed)
+ if (job->method() == "POST") {
+ // Will take care of informing our client...
+ // This must be called before receivedAllData(),
+ // otherwhise assembleResponseHeaders() is called too early...
+ job->receivedResponse(kioJob->queryMetaData("HTTP-Headers"));
+ }
The changes in general look sane. They won't harm any other port. However I
have neither the Qt expertise nor the Loader architecture expertise to really
grill you with this review. If you're comfortable with a "yeah this looks
sane" review, then r=me. Otherwise you'll need to corner maciej when he's
around and ask him about loader architectures. I doubt anyone on the team has
much in the way of Qt expertise.
More information about the webkit-reviews
mailing list