[webkit-reviews] review denied: [Bug 10604] Make regression testing work with Qt (Adding KIO support) : [Attachment 10270] Offer QString -> DeprecatedString conversion

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Aug 28 09:13:14 PDT 2006


Alexey Proskuryakov <ap at nypop.com> has denied Alexey Proskuryakov
<ap at nypop.com>'s request for review:
Bug 10604: Make regression testing work with Qt (Adding KIO support)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10604

Attachment 10270: Offer QString -> DeprecatedString conversion
http://bugzilla.opendarwin.org/attachment.cgi?id=10270&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
According to Qt docs, utf8Data.data() will not be 0 for null arrays, so this
does not convert null strings properly. Yes, this doesn't really matter in
WebCore/platform, but I think we should have this basic conversion right.



More information about the webkit-reviews mailing list