[webkit-reviews] review requested: [Bug 10579] AppleStyleCommand::applyBlockStyle crash : [Attachment 10254] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Aug 27 06:04:47 PDT 2006

Graham Dennis <Graham.Dennis at gmail.com> has asked Justin Garcia
<justin.garcia at apple.com> for review:
Bug 10579: AppleStyleCommand::applyBlockStyle crash

Attachment 10254: patch

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>

I was originally going to try to make sure that the end position of the
selection couldn't end up at the end of a table element, but it seems that the
table deletion code relies on this. So the patch is to make sure that the
'beyondEnd' node is after the start node. The only case when
end.node()->traverseNextNode() is not after the start node is when the end node
is before the start node, which itself can only happen when the end node is an
ancestor of the start node. I think.

More information about the webkit-reviews mailing list