[webkit-reviews] review granted: [Bug 4624] WebCore needs autogenerated Obj-C DOM bindings : [Attachment 10245] DOMCore autogen (addressing more of Tim's comments)

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Aug 26 17:27:01 PDT 2006


Timothy Hatcher <timothy at hatcher.name> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 4624: WebCore needs autogenerated Obj-C DOM bindings
http://bugzilla.opendarwin.org/show_bug.cgi?id=4624

Attachment 10245: DOMCore autogen (addressing more of Tim's comments)
http://bugzilla.opendarwin.org/attachment.cgi?id=10245&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This is great!

Some formatting issues, other than that r=me.

-        attribute long scrollLeft;
+                 attribute [ObjCCatagory=DOMElementExtensions] long
scrollLeft;
 
-        attribute long scrollTop;
+                 attribute [ObjCCatagory=DOMElementExtensions] long scrollTop;


These have some extra whitespace compared to the others.

Check your scripts for tabs, I see a few in there.



More information about the webkit-reviews mailing list