[webkit-reviews] review denied: [Bug 10558] SVG should have support
for <metadata> element : [Attachment 10218] First attempt
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sat Aug 26 02:19:15 PDT 2006
Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10558: SVG should have support for <metadata> element
http://bugzilla.opendarwin.org/show_bug.cgi?id=10558
Attachment 10218: First attempt
http://bugzilla.opendarwin.org/attachment.cgi?id=10218&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
I'm not sure I understand this line:
+ if([meta] == "[object SVGMetadataElement]") {
why the extra [ ] around meta?
Also, this looks wrong:
- JSSVGDocument.h \
Other than that, this patch looks great. r- for the JSSVGDocument.h typo.
More information about the webkit-reviews
mailing list