[webkit-reviews] review granted: [Bug 10467] WebKit should have Qt platform support (Part II) : [Attachment 10149] Patch chunk: graphics related stuff

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Aug 23 13:30:39 PDT 2006


Alexey Proskuryakov <ap at nypop.com> has granted Alexey Proskuryakov
<ap at nypop.com>'s request for review:
Bug 10467: WebKit should have Qt platform support (Part II)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

Attachment 10149: Patch chunk: graphics related stuff
http://bugzilla.opendarwin.org/attachment.cgi?id=10149&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
r=me. There are a number of minor formatting/coding style nitpicks still left
(discussed on IRC). The only more or less substantial pick is that
TransparencyLayer should have a proper destructor, rather than a dangerous
cleanup() method.

This all can go in a follow-up patch, of course.



More information about the webkit-reviews mailing list