[webkit-reviews] review requested: [Bug 6252] JavaScript 1.6 Array.lastIndexOf : [Attachment 10132] lastIndexOf javascript patch REVISION

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Aug 18 12:54:00 PDT 2006


Vladimir Olexa (vladinecko) <vladimir.olexa at gmail.com> has asked  for review:
Bug 6252: JavaScript 1.6 Array.lastIndexOf
http://bugzilla.opendarwin.org/show_bug.cgi?id=6252

Attachment 10132: lastIndexOf javascript patch REVISION
http://bugzilla.opendarwin.org/attachment.cgi?id=10132&action=edit

------- Additional Comments from Vladimir Olexa (vladinecko)
<vladimir.olexa at gmail.com>
This my modified patch from before with following changes:

- minimized the if block ala Darin's suggestion
- fixed indentation issues
- added test cases



More information about the webkit-reviews mailing list