[webkit-reviews] review granted: [Bug 10470] The Qt platform needs
a KCanvas device : [Attachment 10124] Corrected patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Fri Aug 18 11:18:09 PDT 2006
Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10470: The Qt platform needs a KCanvas device
http://bugzilla.opendarwin.org/show_bug.cgi?id=10470
Attachment 10124: Corrected patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10124&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This looks totally fine.
It looks like you misread the style guidelines and added {} around one-line
ifs. :( We'll have to make sure we add an example to the guide.
"If/else statements as above, but if there is an else clause, the close brace
should go on the same line as the else. Also, one-line if or else clauses
should not get braces."
Looks plenty good to land though.
More information about the webkit-reviews
mailing list