[webkit-reviews] review granted: [Bug 10466] WebKit should have Qt platform support : [Attachment 10104] Initial patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Aug 18 01:41:55 PDT 2006

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10466: WebKit should have Qt platform support

Attachment 10104: Initial patch

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This would probably be better as if !PLATFORM(QT)

+	 // use default QCursor constructor. QCursor(0) creates
+	 // an invalid cursor due to implicit constructors ;(
+	 : m_impl(0)
+		{ }

Would be nice to fix the funny spacing while we're there:

     ResourceLoaderInternal * getInternal() { return d;}

No need to name the argument "parent" here, it's implied by the method:

+    virtual void setParentWidget(QWidget* parent);

Same here:

+	 QWidget* parentWidget() const;
+	 virtual void setParentWidget(QWidget* parent);
+	 QWidget* qwidget();
+	 void setQWidget(QWidget* widget);

named arguments in headers often tend to just clutter things.

and another:

+	 virtual void setParentWidget(QWidget* parent);

This is a really nice patch though.


More information about the webkit-reviews mailing list