[webkit-reviews] review denied: [Bug 10343] Windows portability fixes : [Attachment 9975] Fixes for the 2 problems

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Aug 15 21:17:28 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 10343: Windows portability fixes
http://bugzilla.opendarwin.org/show_bug.cgi?id=10343

Attachment 9975: Fixes for the 2 problems
http://bugzilla.opendarwin.org/attachment.cgi?id=9975&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I agree with Eric's comment. The fix for build-generated-files.sh is fine, but
the fix for CSSValueKeywords.in should be in the script, not the source file.
Since this one patch contains both, review- for now.



More information about the webkit-reviews mailing list