[webkit-reviews] review requested: [Bug 8980] ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc]) : [Attachment 10047] Huge scary patch

[bugzilla-request-daemon at opendarwin.org]

Tim Omernick <timo at apple.com> has asked  for review:
Bug 8980: ASSERTION FAILED: !isLoaded
(WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage
dealloc])
http://bugzilla.opendarwin.org/show_bug.cgi?id=8980

Attachment 10047: Huge scary patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10047&action=edit

------- Additional Comments from Tim Omernick <timo at apple.com>
Cleanup and rewrite of WebPluginDatabase:

- When refreshing the plugin database, we will no longer create "throw-away"
plug-in packages for plug-ins that are already in the database.  Plug-in
packages are now uniqued by path.

- Cleaned up the weird load/unload/isLoaded stuff the plug-in package classes. 
Only Netscape plug-ins can truly be "unloaded".  Once a WebKit plug-in bundle
has been loaded, there is no way to unload its bundle.

- Netscape plug-ins packages can once again be safely removed from the database
at runtime.  I broke this when I made the change to explicitly unload plug-ins
packages when they are removed from the database.  A plug-in package is now
unloaded after it is removed from the database, AND all its instances have been
stopped.

- Netscape plug-ins will now properly get an NPP_Shutdown() when the
application quits.  The browser is required to call this function just before
unloading Netscape plug-ins.

- document.plugins.refresh() is now 11% faster in the cold case (never scanned
for plug-ins), and 22% faster in the warm case.